Minimum Days of Service for 1 Service Year

[Huckleberry]

CaseyBlakeDeWitt brought an issue to my attention this evening based on a situation with one of his players. Basically, Matthew Martindale had 3 years and 162 days of major league service time during the offseason when he traded for him. He noticed this evening that Martindale was forecast to go over the 5 year mark this season and therefore be eligible for free agency.

After looking at the settings, I discovered this is because of an an error in the settings. When creating the league I (correctly) told OOTP that the season length would be 156 games. OOTP automatically scaled the setting for Minimum Days of Service for 1 Service Year from 172 as it is in real life to 165 for our league. However, our regular season schedule is 173 days every year. I have changed this setting from 165 days to 173 days for each league.

OOTP should be able to handle this by simply adding exactly 1 year to any player's service time if they meet or exceed the minimum days setting. However that doesn't appear to be what it's doing, so I made the change. Even if it would end up calculating it correctly at the end of the season it is still reporting it incorrectly which will cause owners to make decisions they don't need to make when reviewing their finances and rosters.